Avoid scheduling unnecessary callbacks for cleanup effects

Updated enqueuePendingPassiveEffectDestroyFn() to check rootDoesHavePassiveEffects before scheduling a new callback. This way we'll only schedule (at most) one.
facebook · Jan 31, 2020 · 4ead1e9 · 4ead1e9
1 parent 9a38b12
commit 4ead1e9
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.js b/packages/react-reconciler/src/ReactFiberWorkLoop.js
@@ -2183,11 +2183,13 @@ export function enqueuePendingPassiveEffectDestroyFn(
 ): void {
   if (deferPassiveEffectCleanupDuringUnmount) {
     pendingUnmountedPassiveEffectDestroyFunctions.push(destroy);
-    rootDoesHavePassiveEffects = true;
-    scheduleCallback(NormalPriority, () => {
-      flushPassiveEffects();
-      return null;
-    });
+    if (!rootDoesHavePassiveEffects) {
+      rootDoesHavePassiveEffects = true;
+      scheduleCallback(NormalPriority, () => {
+        flushPassiveEffects();
+        return null;
+      });
+    }
   }
 }