make onKeyPress work

facebook · Apr 4, 2020 · 223785a · 223785a
1 parent c4e3619
commit 223785a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js
@@ -453,7 +453,7 @@ describe('SyntheticKeyboardEvent', () => {
     });
 
     describe('code', () => {
-      it('returns code on `keydown`, `keyup` and null on `keypress`', () => {
+      it('returns code on `keydown`, `keyup` and `keypress`', () => {
         let codeDown = null;
         let codeUp = null;
         let codePress = null;
@@ -488,13 +488,14 @@ describe('SyntheticKeyboardEvent', () => {
         node.dispatchEvent(
           new KeyboardEvent('keypress', {
             code: 'KeyQ',
+            charCode: 113,
             bubbles: true,
             cancelable: true,
           }),
         );
         expect(codeDown).toBe('KeyQ');
         expect(codeUp).toBe('KeyQ');
-        expect(codePress).toBe(null);
+        expect(codePress).toBe('KeyQ');
       });
     });
   });