[eslint-plugin-react-hooks]: handling sparse array when no-inline cal…

…lback (#19145)
facebook · Jun 17, 2020 · 090c6ed · 090c6ed
1 parent cc7c1ae
commit 090c6ed
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js b/packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js
@@ -369,6 +369,20 @@ const tests = {
         }
       `,
     },
+    {
+      code: normalizeIndent`
+        function MyComponent({myEffect}) {
+          useEffect(myEffect, [,myEffect]);
+        }
+      `,
+    },
+    {
+      code: normalizeIndent`
+        function MyComponent({myEffect}) {
+          useEffect(myEffect, [,myEffect,,]);
+        }
+      `,
+    },
     {
       code: normalizeIndent`
         let local = {};

diff --git a/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js b/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
@@ -145,7 +145,7 @@ export default {
           if (
             declaredDependenciesNode.elements &&
             declaredDependenciesNode.elements.some(
-              el => el.type === 'Identifier' && el.name === callback.name,
+              el => el && el.type === 'Identifier' && el.name === callback.name,
             )
           ) {
             // If it's already in the list of deps, we don't care because