Invoke callableModule factory once #44576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `emitDeviceEvent` is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D57329165
Summary: Store callable modules as either a factory function or an object, so we can skip invoking the factory function for frequently accessed objects. Changelog: [Internal] Differential Revision: D57338528
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57338528 |
Base commit: 734ac42 |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 23, 2024
Summary: Store callable modules as either a factory function or an object, so we can skip invoking the factory function for frequently accessed objects. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D57338528
javache
added a commit
to javache/react-native
that referenced
this pull request
May 23, 2024
Summary: Store callable modules as either a factory function or an object, so we can skip invoking the factory function for frequently accessed objects. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D57338528
javache
added a commit
to javache/react-native
that referenced
this pull request
May 23, 2024
Summary: Store callable modules as either a factory function or an object, so we can skip invoking the factory function for frequently accessed objects. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D57338528
|
This pull request has been merged in 1343313. |
|
This pull request was successfully merged by @javache in 1343313. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Store callable modules as either a factory function or an object, so we can skip invoking the factory function for frequently accessed objects.
Changelog: [Internal]
Differential Revision: D57338528