Sanitize measure function results #44557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57285584 |
Summary: We've started seeing assertion failures in Yoga where a `NaN` value makes its way to an `availableHeight` constraint when measuring Litho tree. Because it's only happening on Litho, I have some suspicion this might be originating from a Litho-specific measure function. This adds sanitization in Yoga to measure function results, where we will log an error, and set size to zero, if either dimension ends up being negative of `NaN`. This doesn't really help track down where the error was happening, but Yoga doesn't have great context to show this to begin with. If we see this is issue, next steps would be Litho internal intrumentation to find culprit. Changelog: [Internal] Differential Revision: D57285584
NickGerleman
force-pushed
the
export-D57285584
branch
from
92ea2ad
to
3e2640d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57285584 |
Base commit: 651c1d2 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
May 14, 2024
Summary: X-link: facebook/react-native#44557 We've started seeing assertion failures in Yoga where a `NaN` value makes its way to an `availableHeight` constraint when measuring Litho tree. Because it's only happening on Litho, I have some suspicion this might be originating from a Litho-specific measure function. This adds sanitization in Yoga to measure function results, where we will log an error, and set size to zero, if either dimension ends up being negative of `NaN`. This doesn't really help track down where the error was happening, but Yoga doesn't have great context to show this to begin with. If we see this is issue, next steps would be Litho internal intrumentation to find culprit. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D57285584 fbshipit-source-id: 935fcdd28c05bbac0d73e1c7654ae11a74898537
|
This pull request has been merged in 44f9371. |
|
This pull request was successfully merged by @NickGerleman in 44f9371. When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
May 14, 2024
Summary: X-link: facebook/react-native#44557 We've started seeing assertion failures in Yoga where a `NaN` value makes its way to an `availableHeight` constraint when measuring Litho tree. Because it's only happening on Litho, I have some suspicion this might be originating from a Litho-specific measure function. This adds sanitization in Yoga to measure function results, where we will log an error, and set size to zero, if either dimension ends up being negative of `NaN`. This doesn't really help track down where the error was happening, but Yoga doesn't have great context to show this to begin with. If we see this is issue, next steps would be Litho internal intrumentation to find culprit. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D57285584 fbshipit-source-id: 935fcdd28c05bbac0d73e1c7654ae11a74898537
|
This pull request has been reverted by 1a56b9a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We've started seeing assertion failures in Yoga where a
NaNvalue makes its way to anavailableHeightconstrtaint when measuring Litho nodes.Because it's only happening on Litho, I have some suspicion this might be originating from a Litho-specific measure function. This adds santization in Yoga to measure function results, where we will log an error, and set size to zero, if either dimension ends up being negative of
NaN.Changelog: [Internal]
Differential Revision: D57285584