fix (iOS): fix selectTextOnFocus in Fabric and non-Fabric by calling selectAll after becomeFirstResponder

[haileyok]

Summary:

Fixes #41988

Hopefully even if this isn't the right way to go about solving this, it at least points in the right direction for a different fix!

Currently - both on Paper and Fabric - the selectTextOnFocus prop does not work as expected on a single line text input. It seems that if the UITextField has not yet become the first responder, the text will be briefly selected but then deselected immediately afterward.

This can be seen in the tester when running for either Fabric or Paper (video using Fabric)

selectTextOnFocus-before.mp4

Instead, we can move the selectAll call to reactFocus in RCTBaseTextInputView or focus RCTTextInputComponentView - both of which first call becomeFirstResponder - to get the expected result.

Changelog:

[IOS] [FIXED] - fix selectTextOnFocus in Fabric and non-Fabric by calling selectAll after becomeFirstResponder

Test Plan:

See the rn-tester above prior to these changes. Then test the same against this PR.

RocketSim_Recording_iPhone_15_Pro_6.1_2024-04-28_23.42.26.mp4

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,461,319	-12
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,834,253	+1
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: bb2c13a
Branch: main

[facebook-github-bot]

@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.