Correctly parse partial objects with optional value #44304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: bb2c13a |
Summary: The flow parser *always* returns if a property IS `optional` (true|false) OR not The TypeScript one only emits `optional` if the prop is optional. The current `partialProperty` UTs are not correct. Changelog: [General][Fixed] - Correctly parse partial objects with optional value Differential Revision: D56689387
christophpurrer
force-pushed
the
export-D56689387
branch
from
1198f3f
to
0d3bec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The flow parser always returns if a property IS
optional(true|false) OR notThe TypeScript one only emits
optionalif the prop is optional.The current
partialPropertyUTs are not correct.Changelog: [General][Fixed] - Correctly parse partial objects with optional value
Differential Revision: D56689387