Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI supports ordering of tasks #44301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CLI supports ordering of tasks #44301

wants to merge 1 commit into from

Commits on Apr 29, 2024

  1. CLI supports ordering of tasks 

    Summary:
This gives Frameworks more control in selecting specific tasks and integrating the return types data in their UI.  For example piping `stdout` to the user or using packages like [Listr2](https://www.npmjs.com/package/listr2) to run tasks in parallel and show progress.

The ordering is suggestive (but also enforced by some assertions).  Frameworks are free to do what they want.

The order was implicit in the previous data structure with lists of Tasks, but made it difficult to tap into each async task.

I've also had to rework how we transpile the code if directly executed from the monorepo.  This keeps our:
- flow types valid,
- allows the core-cli-utils package to be built (to generate TypeScript types and a valid npm module), and
- allows direct transpiled execution as a yarn script.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D56242487
    @blakef @facebook-github-bot
    blakef authored and facebook-github-bot committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    38b50da View commit details
    Browse the repository at this point in the history