remove force_static from componentregistry module #44296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Summary: Resolved Pull request: facebook#44296 changelog: [internal] force_static doesn't need to be in here, let's remove it. I change one module per diff. It makes it easier to land it and pinpoint where build failures are coming from. Reviewed By: javache Differential Revision: D56632286
sammy-SC
force-pushed
the
export-D56632286
branch
from
b79e3a4
to
47dfc15
Compare
Base commit: e2ad669 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 28, 2024
Summary: Resolved Pull request: #44296 changelog: [internal] force_static doesn't need to be in here, let's remove it. I change one module per diff. It makes it easier to land it and pinpoint where build failures are coming from. Reviewed By: javache Differential Revision: D56632286 fbshipit-source-id: e942603d3c69d9eebf4d3b64e2f73ee6a5df6de4
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
Summary: Resolved Pull request: facebook#44296 changelog: [internal] force_static doesn't need to be in here, let's remove it. I change one module per diff. It makes it easier to land it and pinpoint where build failures are coming from. Reviewed By: javache Differential Revision: D56632286 fbshipit-source-id: e942603d3c69d9eebf4d3b64e2f73ee6a5df6de4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [interna]
force_static doesn't need to be in here, let's remove it.
I change one module per diff. It makes it easier to land it and pinpoint where build failures are coming from.
Reviewed By: javache
Differential Revision: D56632286