Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing close for canceled bundle downloads #44282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix missing close for canceled bundle downloads #44282

wants to merge 2 commits into from

Commits on Apr 26, 2024

  1. Remove unnecessary overrides in ReactSurfaceView 

    Differential Revision: D54496605
    @javache @facebook-github-bot
    javache authored and facebook-github-bot committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    28a3533 View commit details
    Browse the repository at this point in the history

  2. Fix missing close for canceled bundle downloads 

    Summary: `Response` is `Closeable`, so we must close it even if the download is no longer relevant. Found while running with StrictMode enabled and reloading quickly multiple times.

Differential Revision: D56629079
    @javache @facebook-github-bot
    javache authored and facebook-github-bot committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    82969d3 View commit details
    Browse the repository at this point in the history