Commits on Apr 26, 2024

1. fix a crash in <Modal /> component …

   Summary:
   changelog: [Android][Fixed] - fix a crash in Modal component
   
   Instance variable `propertyRequiresNewDialog` in `ReactModalHostView` controls if new dialog will be created on next `showOrUpdate` or not. It must be kept in sync with `dialog` ivar.
   
   if `dismiss` is ever called from anywhere but `showOrUpdate`, the class gets into a state where the next `showOrUpdate` call will throw an error because dialog is set to null but `propertyRequiresNewDialog` stays false.
   
   `dismiss` is called from three places: `showOrUpdate` (this is ok), `onDropInstance()` and `onDetachedFromWindow`.
   
   The fix in this diff is to make sure propertyRequiresNewDialog is set to true when dialog is dismissed.
   
   Differential Revision: D56627522

   

   sammy-SC authored and facebook-github-bot committed Apr 26, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9d7f8fd
   • Browse repository at this point

   Copy the full SHA

   9d7f8fd View commit details

   Browse the repository at this point in the history