Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Remove _logWarnIfCreateRootViewWithBridgeIsOverridden #44271

Closed
wants to merge 3 commits into from
Closed

[iOS] Remove _logWarnIfCreateRootViewWithBridgeIsOverridden #44271

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9588e37
[iOS] Fixes customizeRootView migration comment
zhongwuzw Apr 26, 2024
5c8b0be
Remove _logWarnIfCreateRootViewWithBridgeIsOverridden
zhongwuzw Apr 26, 2024
25a6c37
Merge branch 'main' into features/fix_comment
cipolleschi May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm
View file
Open in desktop
Expand Up @@ -54,7 +54,6 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
if (self.newArchEnabled || self.fabricEnabled) {
[RCTComponentViewFactory currentComponentViewFactory].thirdPartyFabricComponentsProvider = self;
}
[self _logWarnIfCreateRootViewWithBridgeIsOverridden];
[self customizeRootView:(RCTRootView *)rootView];

self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
Expand Down Expand Up @@ -96,21 +95,6 @@ - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
return rootView;
}

// TODO T173939093 - Remove _logWarnIfCreateRootViewWithBridgeIsOverridden after 0.74 is cut
- (void)_logWarnIfCreateRootViewWithBridgeIsOverridden
{
SEL selector = @selector(createRootViewWithBridge:moduleName:initProps:);
IMP baseClassImp = method_getImplementation(class_getInstanceMethod([RCTAppDelegate class], selector));
IMP currentClassImp = method_getImplementation(class_getInstanceMethod([self class], selector));
if (currentClassImp != baseClassImp) {
NSString *warnMessage =
@"If you are using the `createRootViewWithBridge` to customize the root view appearence,"
"for example to set the backgroundColor, please migrate to `customizeRootView` method.\n"
"The `createRootViewWithBridge` method is not invoked in bridgeless.";
RCTLogWarn(@"%@", warnMessage);
}
}

- (UIViewController *)createRootViewController
{
return [UIViewController new];
Expand Down