Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register globals for idleCallback #44216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cipolleschi
Copy link
Contributor

Summary:
Register Globals to call requestIdleCallback and cancelIdleCallback

Changelog

[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 23, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56472923

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Apr 23, 2024
Summary:

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923
@analysis-bot
Copy link

analysis-bot commented Apr 23, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,477,710 +16,379
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,850,636 +16,384
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: bb2c13a
Branch: main

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Apr 25, 2024
Summary:
Pull Request resolved: facebook#44216

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Reviewed By: sammy-SC

Differential Revision: D56472923
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Apr 25, 2024
Summary:
Pull Request resolved: facebook#44216

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923

Reviewed By: sammy-SC
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Apr 25, 2024
Summary:
Pull Request resolved: facebook#44216

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923

Reviewed By: sammy-SC
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Apr 25, 2024
Summary:
Pull Request resolved: facebook#44216

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923

Reviewed By: sammy-SC
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Apr 25, 2024
Summary:
Pull Request resolved: facebook#44216

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923

Reviewed By: sammy-SC
Riccardo Cipolleschi and others added 3 commits April 28, 2024 10:10
Summary:
Pull Request resolved: facebook#44218

To implement idleCallbacks, we need the concept of priorities, tasks and timeout.

Runtime Scheduler offers all of them, so, as a first step, we want to pass the scheduler to the TimerManager.

## Changelog
[iOS][Added] - Pass the RuntimeScheduler to the TimerManager

Differential Revision: https://internalfb.com/D56471829
Summary:
Pull Request resolved: facebook#44217

This change only adds skelethon methods to register and cancel the idle callbacks

## Changelog
[internal] - add private methods to register callbacks, empty implementation

Differential Revision: https://internalfb.com/D56472138
Summary:
Pull Request resolved: facebook#44216

Register Globals to call `requestIdleCallback` and `cancelIdleCallback`

## Changelog
[General][Added] - Register globals for IdleCallbacks

Differential Revision: D56472923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants