Remove redundant LongLivedObject import in RCTTurboModule.mm #41368
Conversation
|
Hi @hieu9102002! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: bc68794 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
Shared with Meta
hieu9102002
changed the title
There was a problem hiding this comment.
Hi @hieu9102002 Thanks for the contribution. I think it makes sense. Nobody is actually using LongLivedObject in this file! ¯_(ツ)_/¯
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 05d92bf. |
…k#41368) Summary: Similarly to facebook#36391 , we found that this import was periodically causing issues for our builds. We applied this patch and found that it is solving the issue, thus raising the PR here. It may potentially be related to facebook#35664 and facebook#41281 ## Changelog: [IOS] [FIXED] - Unbreak Cocoapods build Pull Request resolved: facebook#41368 Test Plan: Automated test builds should be able to spot out potential issues. Reviewed By: javache Differential Revision: D51117316 Pulled By: cipolleschi fbshipit-source-id: 5c8ee35ab38539ae1f5556202bb274566adf09b3
Summary:
Similarly to #36391 , we found that this import was periodically causing issues for our builds. We applied this patch and found that it is solving the issue, thus raising the PR here.
It may potentially be related to #35664 and #41281
Changelog:
[IOS] [FIXED] - Unbreak Cocoapods build
Test Plan:
Automated test builds should be able to spot out potential issues.