Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cipolleschi/fix CI #40793

Merged
merged 1 commit into from Oct 11, 2023
Merged

cipolleschi/fix CI #40793

merged 1 commit into from Oct 11, 2023

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Oct 11, 2023 •
edited

Summary:

Fix CI for 0.71-stable branch

Changelog:

[iOS][Changed] - Set the proper dependencies for iOS

Test Plan:

CI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 11, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.71-stable October 11, 2023 14:16
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-CI branch 2 times, most recently from 7575de3 to ada023e Compare October 11, 2023 14:25
cipolleschi
cipolleschi commented Oct 11, 2023
View reviewed changes
packages/rn-tester/Gemfile
@@ -1,6 +1,6 @@
# Gemfile
source 'https://rubygems.org'

gem 'cocoapods', '= 1.11.3'
gem 'cocoapods', '>= 1.11.3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this align the Gemfile of RNTester to the Gemfile in root and in the Template.

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-CI branch 2 times, most recently from 5a50c2b to 65979dc Compare October 11, 2023 15:14
@github-actions
Copy link

Fails
🚫

📋 Verify Changelog Format - See Changelog format
Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against c3f0252

@cipolleschi cipolleschi marked this pull request as ready for review October 11, 2023 16:50
@cipolleschi cipolleschi merged commit 4b386c9 into 0.71-stable Oct 11, 2023
50 of 52 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/fix-CI branch October 11, 2023 16:51
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortmarek fortmarek fortmarek approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cipolleschi @fortmarek @facebook-github-bot