Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing C++ include for prop conversion of complex array type #35984

Closed
wants to merge 1 commit into from

Commits on Jan 26, 2023

  1. Add missing C++ include for prop conversion of complex array type

    Summary:
    [Changelog][Internal]
    
    Codegen for props parsing was failing to add a required include for the case when the type is an array of objects, which in turn use non-trivial types.
    
    Something like:
    ```
    export type NativeProps = $ReadOnly<{
      ...ViewProps,
      bounds: $ReadOnlyArray<
        $ReadOnly<{
          height?: Float,
          left?: Float,
          top?: Float,
          width?: Float,
        }>,
      >,
    }>;
    ```
    
    would cause compilation errors on C++ side, since the required header for the `Float` conversion wasn't included.
    
    Reviewed By: cipolleschi
    
    Differential Revision: D42781128
    
    fbshipit-source-id: 5b0ad5c3f5740c1bcb308e56cc4c1854c8f71a6a
    rshest authored and facebook-github-bot committed Jan 26, 2023
    Copy the full SHA
    0d30513 View commit details
    Browse the repository at this point in the history