Add destructuredArrayIgnorePattern to eslint config #33552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
Base commit: 1e51ac2 |
Base commit: 6e0fa5f |
ryancat
reviewed
Apr 4, 2022
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
github-actions
bot
removed
the
Stale
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @fwcd in 0c5ef57. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: This adds the `destructuredArrayIgnorePattern` rule [recently introduced in `typescript-eslint`](typescript-eslint/typescript-eslint#4691), making underscored identifiers in array destructurings no longer an error, e.g. ```js const [state, _dispatch] = useContext(MyContext); ``` would be acceptable if `state` is used. ## Changelog [General] [Added] - Add destructuredArrayIgnorePattern to eslint config Pull Request resolved: facebook#33552 Test Plan: Install the `react-native-community/eslint-config` package and test the example. Reviewed By: lunaleaps, cipolleschi Differential Revision: D40166101 Pulled By: ryancat fbshipit-source-id: 1e30297bf40d65e09682c4f9f3b3dd432ba5310e
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This adds the `destructuredArrayIgnorePattern` rule [recently introduced in `typescript-eslint`](typescript-eslint/typescript-eslint#4691), making underscored identifiers in array destructurings no longer an error, e.g. ```js const [state, _dispatch] = useContext(MyContext); ``` would be acceptable if `state` is used. ## Changelog [General] [Added] - Add destructuredArrayIgnorePattern to eslint config Pull Request resolved: facebook#33552 Test Plan: Install the `react-native-community/eslint-config` package and test the example. Reviewed By: lunaleaps, cipolleschi Differential Revision: D40166101 Pulled By: ryancat fbshipit-source-id: 1e30297bf40d65e09682c4f9f3b3dd432ba5310e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the
destructuredArrayIgnorePatternrule recently introduced intypescript-eslint, making underscored identifiers in array destructurings no longer an error, e.g.would be acceptable if
stateis used.Changelog
[General] [Added] - Add destructuredArrayIgnorePattern to eslint config
Test Plan
Install the
@react-native-community/eslint-configpackage and test the example.