New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ios build error when use_frameworks is on and fabric is off (v2) #33409
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,9 +138,9 @@ - (void)reportFatal:(NSString *)message stack:(NSArray<NSDictionary *> *)stack e | |
} | ||
} | ||
|
||
- (void)reportEarlyJsException:(std::string)errorMap | ||
- (void)reportEarlyJsException:(NSString *)errorMap | ||
{ | ||
NSString *errprStr = [NSString stringWithUTF8String:errorMap.c_str()]; | ||
NSString *errprStr = errorMap; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would these also need revert @dmitryrykun ? just scanning this after seeing your comment and they seem similar There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I meant all the changes in RCTExceptionsManager. |
||
NSData *jsonData = [errprStr dataUsingEncoding:NSUTF8StringEncoding]; | ||
NSError *jsonError; | ||
NSDictionary *dict = [NSJSONSerialization JSONObjectWithData:jsonData | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kudo please revert this change. It is not related to the original issue, and it breaks our internal tests.
Other than that, this solution looks good!