Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start surface after setting the delegate #33402

Closed
wants to merge 1 commit into from
Closed

Start surface after setting the delegate #33402

wants to merge 1 commit into from

Commits on Mar 9, 2022

  1. Start surface after setting the delegate 

    When starting the surface, _propagateStageChange is called. This checks the delegate to call surface:didChangeStage: on it.

When initWithSurface:sizeMeasureMode: is called after start, then the delegate will be nil and thus not be called.

This turns it around so a delegate is present for the surface to propagate its state to.

This fixes RCTContentDidAppearNotification not getting posted otherwise.
    @danilobuerger
    danilobuerger committed Mar 9, 2022
    Copy the full SHA
    9be7385 View commit details
    Browse the repository at this point in the history