Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ReactiveNative compiled with Clang 10 #28362

Closed
wants to merge 1 commit into from
Closed

Get ReactiveNative compiled with Clang 10 #28362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion React/CxxBridge/RCTCxxBridge.mm
View file
Open in desktop
Expand Up @@ -777,7 +777,7 @@ - (void)registerExtraLazyModules
#endif
}

- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules
- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<Class> *)modules
withDispatchGroup:(dispatch_group_t)dispatchGroup
lazilyDiscovered:(BOOL)lazilyDiscovered
{
Expand Down
1 change: 1 addition & 0 deletions ReactCommon/fabric/graphics/platform/ios/Color.cpp
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@
*/

#include "Color.h"
#include <cassert>

namespace facebook {
namespace react {
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm
View file
Open in desktop
Expand Up @@ -308,7 +308,7 @@ - (void)notifyAboutTurboModuleSetup:(const char *)name
@"%@ has no setter or ivar for its bridge, which is not "
"permitted. You must either @synthesize the bridge property, "
"or provide your own setter method.",
RCTBridgeModuleNameForClass(strongModule));
RCTBridgeModuleNameForClass([strongModule class]));
}

[performanceLogger attachRCTBridgeToRCTTurboModuleEnd:moduleName];
Expand Down