Skip to content

Commit

Permalink
Fix experimental_filter validation error in bridgeless (#44524)
Browse files Browse the repository at this point in the history
Summary:
Changelog: [Internal]

Pull Request resolved: #44524

After D56845572, I've started seeing the following redbox when running apps in bridgless mode:

 {F1633641432}

Note sure this is the correct/complete fix but, after this, the error seems to go away.

Reviewed By: RSNara

Differential Revision: D57207925

fbshipit-source-id: c02b9b268c135aabaaa1dc8329abc80ca5c8a500
  • Loading branch information
fabriziocucci authored and facebook-github-bot committed May 13, 2024
1 parent c70d791 commit f44476d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const ReactNativeStyleAttributes = require('../Components/View/ReactNativeStyleA
const resolveAssetSource = require('../Image/resolveAssetSource');
const processColor = require('../StyleSheet/processColor').default;
const processColorArray = require('../StyleSheet/processColorArray');
const processFilter = require('../StyleSheet/processFilter').default;
const insetsDiffer = require('../Utilities/differ/insetsDiffer');
const matricesDiffer = require('../Utilities/differ/matricesDiffer');
const pointsDiffer = require('../Utilities/differ/pointsDiffer');
Expand Down Expand Up @@ -188,6 +189,8 @@ function getProcessorForType(typeName: string): ?(nextProp: any) => any {
return processColor;
case 'ColorArray':
return processColorArray;
case 'Filter':
return processFilter;
case 'ImageSource':
return resolveAssetSource;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public void setBackgroundColor(@NonNull T view, int backgroundColor) {
}

@Override
@ReactProp(name = ViewProps.FILTER)
@ReactProp(name = ViewProps.FILTER, customType = "Filter")
public void setFilter(@NonNull T view, @Nullable ReadableArray filter) {
view.setTag(R.id.filter, filter);
}
Expand Down

0 comments on commit f44476d

Please sign in to comment.