Skip to content

Commit

Permalink
Use logical operator instead of bit operation
Browse files Browse the repository at this point in the history
Summary:
I guess it's the same since we're working on a `bool` but... this causes some compilation error.

Changelog:
[General][iOS] - Fix compilation warning in yoga

Reviewed By: Andrey-Mishanin

Differential Revision: D35438992

fbshipit-source-id: 22bb848dfee435ede66af0a740605d4618585e18
  • Loading branch information
cuva authored and facebook-github-bot committed Apr 12, 2022
1 parent 41cbccd commit 52d8a79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ReactCommon/yoga/yoga/Yoga.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2229,7 +2229,7 @@ static float YGDistributeFreeSpaceSecondPass(
depth,
generationCount);
node->setLayoutHadOverflow(
node->getLayout().hadOverflow() |
node->getLayout().hadOverflow() ||
currentRelativeChild->getLayout().hadOverflow());
}
return deltaFreeSpace;
Expand Down

5 comments on commit 52d8a79

@AmitShimon198
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this bug fixed?

@Yandamuri
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which version of react-native this bug is fixed?

@nbluis
Copy link

@nbluis nbluis commented on 52d8a79 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yandamuri apparently since 0.69

@dio-ralali
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im using 0.64.4 and got the same problem @nbluis @Yandamuri

@Yandamuri
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dio-ralali I faced this issue in 0.68.2. So, if you want this issue to be resolved please upgrade to 0.69 or above as @nbluis suggested.(BTW I have not tested yet in 0.69).

Please sign in to comment.