fix Docusaurus v2 CircleCI/GH-pages deployment #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-native ready! Built with commit 14249ee |
slorber
commented
Oct 29, 2020
| @@ -60,6 +60,7 @@ jobs: | |||
| - restore_cache_checkout | |||
| - run_yarn | |||
| - run: yarn ci-check | |||
| - run: export NODE_OPTIONS=--max_old_space_size=4096 | |||
There was a problem hiding this comment.
A site build requires more than default node memory.
Deploy builds the site and use 4go. But tests workflow also build the site, so it should rather use 4go as well.
Simek
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of Docusaurus v2 migration so that site can go live.
#2263
Note: this site is published to GH pages of react-native repo, not react-native-website repo, which is kind of weird
Highly recommend to migrate Netlify for everything (build production, host production, PR deploy previews) instead of splitting each task between CircleCI/GH-pages/Netlify. One tool is simpler to manage than 3, technically but also for permissions.
Using GH pages is risky at this scale because we can only have 1 deployment per repo, which means any error can make the production fail, while with Netlify we can have 2 deployments side by side and just change the DNS to perform a migration. Also, Netlify allows many more options like server redirects, server caching headers (without the need to use CloudFlare on top)