This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Remove NSNull values from params dictionaries #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS JS null values are serialized as
NSNull
, this causes issues with the method that serializes parameters in the fbsdk. On android null values are simply ignored so this brings the same behaviour to iOS.Test Plan:
Try calling the various methods that take a parameters object with null values and make sure they are removed.