Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notNull modifier #59

Closed
wants to merge 1 commit into from
Closed

Conversation

lukescott
Copy link

Fixes #57

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jharris4
Copy link

I was just thinking about creating a PR for almost this exact same feature, except I was thinking of calling it isDefined instead of notNull.

Basically, I have a case where I want to allow null but disallow undefined.

@lukescott
Copy link
Author

Closing in favor of #90

@lukescott lukescott closed this Jul 13, 2017
@jharris4
Copy link

@lukescott thanks for the initial work on this, hope you don't feel like I stepped on your toes making a similar PR ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants