Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG #40

Merged
merged 6 commits into from May 3, 2017
Merged

Add CHANGELOG #40

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
07d6f5a
Add CHANGELOG
flarnie Apr 27, 2017
f433938
Improve `CHANGELOG` entries
flarnie Apr 27, 2017
112f708
Further corrections to CHANGELOG
flarnie Apr 28, 2017
78393c7
Add change log for v15.5.4-15.5.8 - credit to @gaearon
flarnie Apr 28, 2017
019a3a9
Move annotations for v15.5.1-3 around in change log
flarnie May 1, 2017
4da3fa9
Final nit fixes to CHANGELOG
flarnie May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -0,0 +1,14 @@
## 15.5.4
* Fix UMD Build. [See this commit](https://github.com/reactjs/prop-types/commit/31e9344ca3233159928da66295da17dad82db1a8).
* Remove dependencies on React in `package.json`. [See this commit](https://github.com/reactjs/prop-types/commit/158198fd6c468a3f6f742e0e355e622b3914048a).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't removing a dependency. Just fixing a bad package URL. (Wouldn't affect installs.)


## 15.5.3
* Inlined 'React.isValidElement' to eliminate dependency on React. [See #9371](https://github.com/facebook/react/issues/9371#issuecomment-292685424)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should use backticks instead of single quotes here for formatting.
But I would probably just say "Remove the dependency on the react package"

and [this commit](https://github.com/reactjs/prop-types/commit/df318bba8a89bc5aadbb0292822cf4ed71d27ace).

## 15.5.2
Copy link
Contributor

@gaearon gaearon Apr 28, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 15.5.2 added the UMD build (worth mentioning). But it was unnecessarily large by mistake.

https://unpkg.com/prop-types@15.5.2/prop-types.js
https://unpkg.com/prop-types@15.5.2/prop-types.min.js

Then 15.5.4 fixed its size (18 -> 4 kB pre gzip).

* Fix bug where `prop-types` module was built with const instead of var `lib/ReactPropTypesSecret.js`. [See #9370](https://github.com/facebook/react/issues/9370) and [this commit](https://github.com/facebook/react/commit/e1919638b39dd65eedd250a8bb649773ca61b6f1).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Why the weird whitespace? [See•••••••••••••#9370]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we do not get too technical in error messages. We never did before, and I think our format worked fairly well. So instead we could phrase this as:

  • Remove accidental uncompiled ES6 syntax in the published package.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 15.5.2 is the one that actually removed the (implicit) dependency on react:

https://unpkg.com/prop-types@15.5.2/index.js

Compare to 15.5.1:

https://unpkg.com/prop-types@15.5.1/index.js

## Before 15.5.2

PropTypes was previously included in React, but is now a separate package. For earlier history of PropTypes [see the React change log.](https://github.com/facebook/react/blob/master/CHANGELOG.md)