Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node Corepack #397

Closed
wants to merge 1 commit into from
Closed

Add support for Node Corepack #397

wants to merge 1 commit into from

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Apr 19, 2023

Node ships with Corepack, a "package manager manager". It works by reading packageManager entry in package.json and downloading required binaries transparently, on-the-fly. Therefore it ensures that all developers using Corepack run the same version of package manager:

  • reducing changes for any incompatibilities that might be caused by different versions,
  • making installation seamless - Yarn is installed transparently without any intervention, provided you have Corepack enabled
  • making migration to e.g. modern Yarn or pnpm very easy, as developers don't need to take any further actions besides pulling the latest changes from origin

This PR does not break the repository for those using Yarn Classic (v1) installed using standalone installer, while adding an easy way to contribute for those who did not install it.

@ljharb
Copy link
Collaborator

ljharb commented Apr 20, 2023

This seems like something that would only benefit maintainers of prop-types, which is basically just me at this point - and if it were up to me this repo wouldn't be using yarn, it'd be using npm, and not via corepack, so i'm not sure if this is worth adding.

@wojtekmaj wojtekmaj closed this by deleting the head repository Jun 6, 2023
@wojtekmaj
Copy link
Contributor Author

Well, without this change, you're limiting the number of people that could contribute and gain nothing, but as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants