Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #328 CheckPropTypes break error stack #336

Closed
wants to merge 1 commit into from
Closed

Fixed issue #328 CheckPropTypes break error stack #336

wants to merge 1 commit into from

Conversation

haneenmahd
Copy link

checkPropTypes breaks error statement and produce a warning statement.
Check Issue #328 for details.

checkPropTypes breaks error statement and produce a warning statement.
Check Issue #328 for details.
@facebook-github-bot
Copy link

Hi @haneenmahd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@haneenmahd haneenmahd changed the title Fixed issue #328 Fixed issue #328 CheckPropTypes break error stack Feb 13, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ljharb
Copy link
Collaborator

ljharb commented May 18, 2021

Marked as a draft, pending the bugfix in Chrome that would make this unnecessary.

@ljharb ljharb marked this pull request as draft May 18, 2021 20:44
@haneenmahd haneenmahd marked this pull request as ready for review May 19, 2021 10:34
@ljharb ljharb marked this pull request as draft November 29, 2021 07:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants