Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace error log with warn #251

Closed
wants to merge 1 commit into from
Closed

Replace error log with warn #251

wants to merge 1 commit into from

Conversation

vkhv
Copy link

@vkhv vkhv commented Jan 30, 2019

It difficult to find real error in a big project, when you have no way fix components of other teams.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vkhv vkhv changed the title Update error log with warn Replace error log with warn Jan 30, 2019
@threepointone
Copy link

how would making it warn instead fix that problem?

@ljharb
Copy link
Collaborator

ljharb commented Feb 21, 2019

This is a duplicate of #245; also a duplicate of #63, so I'm going to close it.

@ljharb ljharb closed this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants