.set and .setOf #191
Draft
.set and .setOf #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jun 5, 2018
| function createSetTypeChecker(expectedType) { | ||
| function validate(props, propName, componentName, location, propFullName, secret) { | ||
| var propValue = props[propName]; | ||
| if (!(propValue instanceof Set)) { |
There was a problem hiding this comment.
indeed, this should module-level-cache the getter for Set.prototype.size, call-bind it, and invoke it here.
| return new PropTypeError('Property `' + propFullName + '` of component `' + componentName + '` has invalid PropType notation inside setOf.'); | ||
| } | ||
| var propValue = props[propName]; | ||
| if (!(propValue instanceof Set)) { |
| @@ -505,6 +553,8 @@ module.exports = function(isValidElement, throwOnDirectAccess) { | |||
| return 'date'; | |||
| } else if (propValue instanceof RegExp) { | |||
| return 'regexp'; | |||
| } else if (propValue instanceof Set) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation for
.setand.setOf. Please hit me with your feedback, thoughts, and ideas.I can implement
.mapand.mapOfin this PR as well.@ljharb mentioned that
instanceof Setdoes not work everywhere. Perhaps that has to be fixed.