Test P-521 #349
Merged
Test P-521 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails because of RustCrypto/elliptic-curves#965, which we are going to wait for anyway. |
daxpedda
force-pushed
the
p521
branch
3 times, most recently
from
518cfe3
to
77970d7
Compare
|
This is ready to merge now. |
|
It seems like the maintenance for full_test.rs is getting more and more cumbersome now... any thoughts for how we can make this simpler? And maybe for now, can you also add (in a comment above each new set of constants in full_test.rs) instructions for the cargo command to re-generate those constants? |
|
Last two commits should address both concerns. |
kevinlewi
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds testing of P-521 through the
p521crate.Still requires:
FieldElementconversions can panic RustCrypto/elliptic-curves#965See #290 for a previously similar addition.
See facebook/voprf#127 for the same PR in
voprf, which isn't required to merge this.