Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating rand_core to 0.6 (without curve25519-dalek library change) #131

Merged
merged 1 commit into from Feb 5, 2021
Merged

Updating rand_core to 0.6 (without curve25519-dalek library change) #131

merged 1 commit into from Feb 5, 2021

Conversation

kevinlewi
Copy link
Contributor

Same goal as #103, but without adjusting any curve25519-dalek library dependencies.

This is because we can just rely on calling the internals of Scalar::random in the one place where it is used.

Closes #101

cc: @PaulGrandperrin

@kevinlewi kevinlewi mentioned this pull request Feb 5, 2021
Closed
huitseeker
huitseeker approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, definitely the cleaner approach at this point.

@kevinlewi kevinlewi merged commit 6307ea9 into facebook:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update rand_core to 0.6
3 participants
@kevinlewi @huitseeker @facebook-github-bot