Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving id_u and id_s from the client API to registration finish #102

Merged
merged 1 commit into from Dec 17, 2020
Merged

Moving id_u and id_s from the client API to registration finish #102

merged 1 commit into from Dec 17, 2020

Conversation

kevinlewi
Copy link
Contributor

See #100 for context

huitseeker
huitseeker approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! Thanks (to you & @PaulGrandperrin)

@kevinlewi kevinlewi linked an issue Dec 17, 2020 that may be closed by this pull request
Allow providing (idU, idS) at ClientRegistrationFinish phase (sometimes also named RegistrationUpload in the doc) #100
Closed
@kevinlewi kevinlewi merged commit f5b5391 into facebook:master Dec 17, 2020
@PaulGrandperrin PaulGrandperrin mentioned this pull request Dec 27, 2020
Closed
@kevinlewi kevinlewi deleted the client_finish_ids branch January 22, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
3 participants
@kevinlewi @huitseeker @facebook-github-bot