Reset npm token before yarn install to fix npm publish script #902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
Last two release of metro is not published to npm
v0.73.5
andv0.73.4
, npm still have v0.73.3.Reason:
In circle CI the job
publish-to-npm
is failing because of a preinstall validation which checks for presence ofNPM_TOKEN
while runningyarn install
.Fix:
From file blame I see previously NPM_TOKEN were reset just before yarn install. I am restoring the fix with a comment to make it clear.
Test plan
ssh into circle-ci and ran
NPM_TOKEN= yarn --frozen-lockfile --non-interactive
and can see yarn install working as expected.Before:
After: