Use node devtools url #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Note that the Profiler tab is currently broken in flipper, see facebook/flipper#3355 However this functionality is not working currently anyway since it's not integrated with hermes so it should not block this. |
|
@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks @janicduplessis ! |
ericanderson
added a commit
to ericanderson/metro
that referenced
this pull request
Feb 9, 2022
* upstream/main: Use node devtools url (facebook#761) Publish 0.68.0 fix(website): add Algolia search API key (facebook#726) Change github actions trigger to use `main` branch (facebook#769) RN preset: support async iterators, for await of (facebook#747) Deploy 0.171.0 to xplat
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Mar 14, 2022
Summary: **Summary** This uses the new chrome devtools ui, this is the one used by the nodejs inspector. It is more focused on js debugging / profiling instead of general browser devtools. **Test plan** Tested that it works in Flipper and also when opened directly in chrome. ### Before <img width="1396" alt="image" src="https://user-images.githubusercontent.com/2677334/150821665-1e27e6bb-62da-4d1c-8f0b-2b980c2135fe.png"> ### After <img width="1397" alt="image" src="https://user-images.githubusercontent.com/2677334/150821129-ac55243f-3a77-47cf-907c-651568e7215b.png"> Pull Request resolved: facebook#761 Reviewed By: arushikesarwani94 Differential Revision: D34105401 Pulled By: rh389 fbshipit-source-id: f4be7c3e642542e7f90a1c8b9f7535505fffceeb
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 21, 2022
Summary: **Summary** This uses the new chrome devtools ui, this is the one used by the nodejs inspector. It is more focused on js debugging / profiling instead of general browser devtools. **Test plan** Tested that it works in Flipper and also when opened directly in chrome. ### Before <img width="1396" alt="image" src="https://user-images.githubusercontent.com/2677334/150821665-1e27e6bb-62da-4d1c-8f0b-2b980c2135fe.png"> ### After <img width="1397" alt="image" src="https://user-images.githubusercontent.com/2677334/150821129-ac55243f-3a77-47cf-907c-651568e7215b.png"> Pull Request resolved: facebook#761 Reviewed By: arushikesarwani94 Differential Revision: D34105401 Pulled By: rh389 fbshipit-source-id: f4be7c3e642542e7f90a1c8b9f7535505fffceeb
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 22, 2022
Summary: **Summary** This uses the new chrome devtools ui, this is the one used by the nodejs inspector. It is more focused on js debugging / profiling instead of general browser devtools. **Test plan** Tested that it works in Flipper and also when opened directly in chrome. ### Before <img width="1396" alt="image" src="https://user-images.githubusercontent.com/2677334/150821665-1e27e6bb-62da-4d1c-8f0b-2b980c2135fe.png"> ### After <img width="1397" alt="image" src="https://user-images.githubusercontent.com/2677334/150821129-ac55243f-3a77-47cf-907c-651568e7215b.png"> Pull Request resolved: facebook#761 Reviewed By: arushikesarwani94 Differential Revision: D34105401 Pulled By: rh389 fbshipit-source-id: f4be7c3e642542e7f90a1c8b9f7535505fffceeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This uses the new chrome devtools ui, this is the one used by the nodejs inspector. It is more focused on js debugging / profiling instead of general browser devtools.
Test plan
Tested that it works in Flipper and also when opened directly in chrome.
Before
After