feat: add visionOS support #1358

okwasniewski · 2024-03-19T13:23:51Z

Summary

This PR adds support for visionOS.

Note: Unreleased version of CMake 3.28.4 is required to build for visionOS. We might need to wait until it gets released.

Things to sort out:

Add CI

Test Plan

Build test app for visionOS

matthargett · 2024-03-22T19:16:08Z

both cmake 3.28.4 and 3.29 are released! https://cmake.org/download/

tmikov · 2024-03-22T23:06:55Z

Out of curiosity, what functionality was needed in CMake?

tmikov · 2024-03-22T23:08:41Z

hermes-engine.podspec

@@ -24,13 +24,14 @@ Pod::Spec.new do |spec|
  # The podspec would be serialized to JSON and people will download prebuilt binaries instead of the source.


I don't think React Native uses this file. It is pretty outdated, I think.

It was needed to make the internal hermes tests work and properly build in Xcode

matthargett · 2024-03-23T01:31:12Z

Out of curiosity, what functionality was needed in CMake?

There were a few bugs/enhancements like this one when linking a simulator binary versus a real device binary:
https://gitlab.kitware.com/cmake/cmake/-/issues/25188

neildhar · 2024-03-25T22:33:12Z

Thanks for working on this, most of the changes seem safe and in line with the existing implementation (apart from the tests failures). I know this isn't quite ready yet, but we took a look and wanted to share some thoughts.

Why do we need to edit the CircleCI Android job?
Can we avoid using brew update? We deliberately disable automatically running brew update in our CircleCI jobs because we have had problems with it in the past. Could we omit that step? (potentially by using a newer version of the image if necessary)
What happens if an older version of CMake is used? If CMake doesn't already provided a descriptive error, perhaps we should add one.

okwasniewski · 2024-03-26T08:22:02Z

Hey @neildhar,

For some reason when I updated the file Android job started failing with this error, I followed suggestions from the CircleCI blog post and set it to default:
I've updated to Xcode 15.3 image let's see if this will pull newer version of Cmake
The older version of CMake contained a bug that lead to always building a version for the real device which wouldn't allow us to run the Xcode test. If you prefer I can remove Xcode test

okwasniewski · 2024-03-26T10:14:22Z

So without a brew upgrade, we are installing CMake 3.28.3 (and 3.28.4) is required for Apple Vision 😕

tmikov · 2024-03-26T22:01:21Z

The problem with running brew update is that we end up potentially performing every test run with different versions of tools.

Can we specify explicit versions to brew install?
If we are building for VisionOS Simulator, can we add a cmake version check. Something like:

if(CMAKE_VERSION VERSION_LESS 3.28.4)
  message("VisionOS Simulator requires CMake version >= 3.28.4")
endif()

neildhar · 2024-03-29T18:21:23Z

@okwasniewski I think the Android image issue should be addressed by #1364, so you should be able to remove those changes from this PR

okwasniewski · 2024-04-24T12:05:20Z

@neildhar I've applied your comment. CMake is now installed separately.

facebook-github-bot · 2024-04-24T17:26:56Z

@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

.circleci/config.yml

facebook-github-bot · 2024-04-24T17:32:50Z

@okwasniewski has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2024-04-24T19:06:35Z

@okwasniewski has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2024-04-24T22:17:43Z

@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

okwasniewski · 2024-04-30T13:20:30Z

Hey! Is there anything I can do to help you resolve those internal build issues?

neildhar · 2024-04-30T17:23:30Z

Hey @okwasniewski, I tried doing some cleanup internally to minimise changes but can't export them back out to your PR.

Could you apply this patch to the CI config? It addresses some lints and removes changes in jobs that do not build for visionOS.

@@ -5,16 +5,6 @@
   android: circleci/android@2.0.3
   node: circleci/node@4.7.0

-commands:
-  # Install latest CMake version, needed for building Hermes for visionOS which requires at least CMake 3.29.
-  brew-install-cmake:
-    steps:
-      - run:
-          name: Install CMake
-          command: |
-            brew update
-            brew install cmake
-
 workflows:
   version: 2
   build:
@@ -176,11 +166,6 @@
       - restore_cache:
           key: v4-repo-{{ .Environment.CIRCLE_SHA1 }}
       - run:
-          name: Install dependencies
-          command: |
-            brew install ninja
-      - brew-install-cmake
-      - run:
           name: Build the test application
           command: |
             pod install
@@ -227,9 +212,12 @@
       - run:
           name: Install dependencies
           command: |
-            brew install ninja
             sudo gem install cocoapods
-      - brew-install-cmake
+            # TODO: Building for Apple Vision Pro requires a newer version of
+            # CMake than is available by default. Remove "brew update" once the
+            # CircleCI image contains CMake > 3.29.2.
+            brew update
+            brew install cmake
       - run:
           name: Build the iOS frameworks
           command: ./utils/build-ios-framework.sh
@@ -259,9 +247,10 @@
       - run:
           name: Install dependencies
           command: |
-            brew install cmake
             sudo gem install cocoapods
-      - brew-install-cmake
+            # TODO: See comment in build-apple-runtime.
+            brew update
+            brew install cmake
       - run:
           name: Package the framework
           command: |
@@ -289,7 +278,7 @@

   macos:
     macos:
-      xcode: 15.3
+      xcode: 13.4.1
     steps:
       - checkout:
           path: hermes
@@ -327,12 +316,15 @@

   test-macos:
     macos:
-      xcode: 15.3
+      xcode: 13.4.1
     steps:
       - checkout:
           path: hermes
-      - brew-install-cmake
       - run:
+          name: Install dependencies
+          command: |
+            brew install cmake
+      - run:
           name: Run MacOS regression tests in debug mode
           command: |
             cmake -S hermes -B build -GXcode
@@ -701,7 +693,7 @@

   test-macos-test262:
     macos:
-      xcode: 15.3
+      xcode: 13.4.1
     steps:
       - checkout:
           path: hermes

facebook-github-bot · 2024-05-06T15:12:02Z

@okwasniewski has updated the pull request. You must reimport the pull request before landing.

okwasniewski · 2024-05-06T15:13:48Z

Hey @neildhar, sorry for the delay I was on time off. I've updated the PR, hopefully the tests will be green now 🤞

neildhar · 2024-05-06T21:52:50Z

.circleci/config.yml

@@ -165,10 +165,6 @@ jobs:
      - checkout
      - restore_cache:
          key: v4-repo-{{ .Environment.CIRCLE_SHA1 }}
-      - run:


I apologise, I thought testing didn't require CMake, but it looks like pod install is looking for it. We should add the same thing here with a comment.

facebook-github-bot · 2024-05-07T07:17:42Z

@okwasniewski has updated the pull request. You must reimport the pull request before landing.

ci: update to Xcode 15.2 feat: add visionos to podspec add xr framework metadata fix: set correct target for xros feat: temp workaround for CMake bug

facebook-github-bot · 2024-05-07T07:17:58Z

@okwasniewski has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2024-05-08T23:59:22Z

@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2024-05-09T15:54:30Z

@neildhar merged this pull request in dda343b.

facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 19, 2024

okwasniewski force-pushed the feat/visionos branch 3 times, most recently from fabb2be to 2d92e23 Compare March 21, 2024 12:11

tmikov reviewed Mar 22, 2024

View reviewed changes

okwasniewski force-pushed the feat/visionos branch 9 times, most recently from 0e503ec to 484be5b Compare March 25, 2024 13:30

okwasniewski force-pushed the feat/visionos branch from 484be5b to 12a64fb Compare March 26, 2024 08:21

okwasniewski force-pushed the feat/visionos branch 3 times, most recently from f33c5bd to d2f90af Compare March 26, 2024 15:51

okwasniewski force-pushed the feat/visionos branch 2 times, most recently from 6784b01 to 439d599 Compare March 28, 2024 14:13

okwasniewski force-pushed the feat/visionos branch from 439d599 to ca1640d Compare April 2, 2024 09:48

okwasniewski marked this pull request as ready for review April 2, 2024 10:33

okwasniewski force-pushed the feat/visionos branch 5 times, most recently from 71607be to b9a8dd2 Compare April 24, 2024 10:39

neildhar reviewed Apr 24, 2024

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

okwasniewski force-pushed the feat/visionos branch from 239881a to 1d4fe88 Compare April 24, 2024 19:06

okwasniewski force-pushed the feat/visionos branch from 1d4fe88 to b9a8dd2 Compare April 24, 2024 19:14

okwasniewski mentioned this pull request Apr 30, 2024

Asset validation failed - A key for 'MinimumOSVersion' is required callstack/react-native-visionos#101

Open

okwasniewski force-pushed the feat/visionos branch from b9a8dd2 to b9f6431 Compare May 6, 2024 15:11

neildhar reviewed May 6, 2024

View reviewed changes

okwasniewski force-pushed the feat/visionos branch from b9f6431 to 888657f Compare May 7, 2024 07:17

feat: add visionOS support

8ca3eb8

ci: update to Xcode 15.2 feat: add visionos to podspec add xr framework metadata fix: set correct target for xros feat: temp workaround for CMake bug

okwasniewski force-pushed the feat/visionos branch from 888657f to 8ca3eb8 Compare May 7, 2024 07:17

facebook-github-bot closed this in dda343b May 9, 2024

facebook-github-bot added the Merged label May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add visionOS support #1358

feat: add visionOS support #1358

okwasniewski commented Mar 19, 2024 •

edited

matthargett commented Mar 22, 2024

tmikov commented Mar 22, 2024

tmikov Mar 22, 2024

okwasniewski Mar 25, 2024 •

edited

matthargett commented Mar 23, 2024

neildhar commented Mar 25, 2024

okwasniewski commented Mar 26, 2024

okwasniewski commented Mar 26, 2024

tmikov commented Mar 26, 2024

neildhar commented Mar 29, 2024

okwasniewski commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

okwasniewski commented Apr 30, 2024

neildhar commented Apr 30, 2024

facebook-github-bot commented May 6, 2024

okwasniewski commented May 6, 2024

neildhar May 6, 2024

facebook-github-bot commented May 7, 2024

facebook-github-bot commented May 7, 2024

facebook-github-bot commented May 8, 2024

facebook-github-bot commented May 9, 2024

		@@ -24,13 +24,14 @@ Pod::Spec.new do \|spec\|
		# The podspec would be serialized to JSON and people will download prebuilt binaries instead of the source.

feat: add visionOS support #1358

feat: add visionOS support #1358

Conversation

okwasniewski commented Mar 19, 2024 • edited

Summary

Things to sort out:

Test Plan

matthargett commented Mar 22, 2024

tmikov commented Mar 22, 2024

tmikov Mar 22, 2024

Choose a reason for hiding this comment

okwasniewski Mar 25, 2024 • edited

Choose a reason for hiding this comment

matthargett commented Mar 23, 2024

neildhar commented Mar 25, 2024

okwasniewski commented Mar 26, 2024

okwasniewski commented Mar 26, 2024

tmikov commented Mar 26, 2024

neildhar commented Mar 29, 2024

okwasniewski commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

facebook-github-bot commented Apr 24, 2024

okwasniewski commented Apr 30, 2024

neildhar commented Apr 30, 2024

facebook-github-bot commented May 6, 2024

okwasniewski commented May 6, 2024

neildhar May 6, 2024

Choose a reason for hiding this comment

facebook-github-bot commented May 7, 2024

facebook-github-bot commented May 7, 2024

facebook-github-bot commented May 8, 2024

facebook-github-bot commented May 9, 2024

okwasniewski commented Mar 19, 2024 •

edited

okwasniewski Mar 25, 2024 •

edited