Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow serializing undefined in object literals #1314

Open
wants to merge 6 commits into
base: static_h
Choose a base branch
from
Open

Allow serializing undefined in object literals #1314

wants to merge 6 commits into from

Commits on Feb 16, 2024

  1. Delete shermes date-locale test 

    Differential Revision: D53838779
    @neildhar @facebook-github-bot
    neildhar authored and facebook-github-bot committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    de18133 View commit details
    Browse the repository at this point in the history

  2. Use literal visitor for array literals in interpreter 

    Differential Revision: D29760022
    @neildhar @facebook-github-bot
    neildhar authored and facebook-github-bot committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e2774d1 View commit details
    Browse the repository at this point in the history

  3. Use literal visitor for object keys in interpreter 

    Differential Revision: D29760023
    @neildhar @facebook-github-bot
    neildhar authored and facebook-github-bot committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    fe06b5c View commit details
    Browse the repository at this point in the history

  4. Use literal visitor for object values in the interpreter 

    Differential Revision: D29760024
    @neildhar @facebook-github-bot
    neildhar authored and facebook-github-bot committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ff84738 View commit details
    Browse the repository at this point in the history

  5. Clean up old serialized literal parser 

    Differential Revision: D29775882
    @neildhar @facebook-github-bot
    neildhar authored and facebook-github-bot committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4b4c0ef View commit details
    Browse the repository at this point in the history

  6. Allow serializing undefined in object literals 

    Summary:
Optional fields and fields that refer to other classes are initialised
to `undefined`, which means that we often end up with `undefined` in
literals now.

To address this, add the ability to serialize undefined, at the expense
of eliminating the `ByteString` tag.

Differential Revision: D45014095
    @neildhar @facebook-github-bot
    neildhar authored and facebook-github-bot committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d38bc6c View commit details
    Browse the repository at this point in the history