Fix a race condition with ninja 1.12.0 #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 8, 2024
Address a potential race condition where generated headers not created before they used in the build. facebook/fbthrift#599 PR: 278693 Approved by: portmgr (blanket)
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 13, 2024
Summary: Fix a race condition that exists when building with ninja 1.12.0 where any_rep_types.h is not generated before attempting to compile Any.cpp. `[ 57% 214/369] /usr/local/libexec/ccache/c++ -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -DTHRIFT_HAVE_LIBSNAPPY=0 -Dthrifttype_EXPORTS -I/wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/. -I/wrkdirs/usr/ports/devel/fbthrift/work/.build -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -DNDEBUG -std=c++17 -fPIC -pthread -fsized-deallocation -MD -MT thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -MF thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o.d -o thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -c /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/thrift/lib/cpp2/type/Any.cpp` `FAILED: thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o` `/usr/local/libexec/ccache/c++ -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -DTHRIFT_HAVE_LIBSNAPPY=0 -Dthrifttype_EXPORTS -I/wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/. -I/wrkdirs/usr/ports/devel/fbthrift/work/.build -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -DNDEBUG -std=c++17 -fPIC -pthread -fsized-deallocation -MD -MT thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -MF thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o.d -o thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -c /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/thrift/lib/cpp2/type/Any.cpp In file included from /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/thrift/lib/cpp2/type/Any.cpp:17: /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/./thrift/lib/cpp2/type/Any.h:23:10: fatal error: 'thrift/lib/thrift/gen-cpp2/any_rep_types.h' file not found` `#include <thrift/lib/thrift/gen-cpp2/any_rep_types.h>` ` ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~` `1 error generated.` `ninja: build stopped: subcommand failed.` `*** Error code 1` X-link: facebook/fbthrift#599 Reviewed By: vitaut Differential Revision: D57138546 Pulled By: Orvid fbshipit-source-id: 7c59885e927c22f58c92a7f2a0a5f84331a67b9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition that exists when building with ninja 1.12.0 where any_rep_types.h is not generated before attempting to compile Any.cpp.
[ 57% 214/369] /usr/local/libexec/ccache/c++ -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -DTHRIFT_HAVE_LIBSNAPPY=0 -Dthrifttype_EXPORTS -I/wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/. -I/wrkdirs/usr/ports/devel/fbthrift/work/.build -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -DNDEBUG -std=c++17 -fPIC -pthread -fsized-deallocation -MD -MT thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -MF thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o.d -o thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -c /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/thrift/lib/cpp2/type/Any.cppFAILED: thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o/usr/local/libexec/ccache/c++ -DFMT_SHARED -DGFLAGS_IS_A_DLL=0 -DTHRIFT_HAVE_LIBSNAPPY=0 -Dthrifttype_EXPORTS -I/wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/. -I/wrkdirs/usr/ports/devel/fbthrift/work/.build -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -DGLOG_USE_GLOG_EXPORT -DNDEBUG -std=c++17 -fPIC -pthread -fsized-deallocation -MD -MT thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -MF thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o.d -o thrift/lib/cpp2/CMakeFiles/thrifttype.dir/type/Any.cpp.o -c /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/thrift/lib/cpp2/type/Any.cpp In file included from /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/thrift/lib/cpp2/type/Any.cpp:17: /wrkdirs/usr/ports/devel/fbthrift/work/fbthrift-2024.05.02.00/./thrift/lib/cpp2/type/Any.h:23:10: fatal error: 'thrift/lib/thrift/gen-cpp2/any_rep_types.h' file not found#include <thrift/lib/thrift/gen-cpp2/any_rep_types.h>^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~1 error generated.ninja: build stopped: subcommand failed.*** Error code 1