Skip to content

Commit

Permalink
Add 'unspecified' to error blame
Browse files Browse the repository at this point in the history
Summary: This can help track down errors where the blame has not been set.

Reviewed By: yfeldblum

Differential Revision: D26797693

fbshipit-source-id: da0714c0fca949db93d437960d60bb2e710f52a3
  • Loading branch information
Alfred Fuller authored and facebook-github-bot committed Mar 4, 2021
1 parent 395eb3e commit 27547e2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions thrift/compiler/ast/t_exception.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,15 @@ namespace thrift {
namespace compiler {

enum class t_error_kind {
transient = 0, // The associated RPC may succeed if retried.
transient = 0, // The associated RPC might succeed if retried.
stateful, // Server state must be change for the associated RPC to have
// any chance of succeeding.
permanent, // The associated RPC can never succeed, and should not be retried.
};

enum class t_error_blame {
server = 0, // The error was the fault of the server.
unspecified = 0, // The blame for the error was not specified.
server, // The error was the fault of the server.
client, // The error was the fault of the client's request.
};

Expand Down

0 comments on commit 27547e2

Please sign in to comment.