Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @fbtjs/default-collection-transform as a peer dep from babel-plugin-fbt. #415

Closed
wants to merge 1 commit into from

Conversation

cpojer
Copy link
Contributor

@cpojer cpojer commented Apr 24, 2024

Summary

The default collection transform is an example, and does not need to be used directly. In my case, I have my own collection transform and it doesn't make sense for package manager to suggest installing the default collection transform in such cases. I suggest removing it as a peer dep.

Test plan

yolo

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 24, 2024
@voideanvalue
Copy link
Contributor

@cpojer
Copy link
Contributor Author

cpojer commented Apr 25, 2024

Actually neither might be a good idea since it is actually required in code when no custom transformer is specified:

const transform = require('@fbtjs/default-collection-transform');

I feel like it would be better to push this into the config where the collection transform is required to be specified via path or something. 🤷🏻‍♂️

@cpojer cpojer closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants