Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add typescript definitions for fbt module #261

Closed
wants to merge 1 commit into from
Closed

[feat] Add typescript definitions for fbt module #261

wants to merge 1 commit into from

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Aug 25, 2021 •
edited

Summary

Issues: #49 #202

Test plan

  • Use typescript@4.2.x and above
  • Add "skipLibCheck": false, in tsconfig.json
  • Run yarn tsc

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 25, 2021
@retyui
Copy link
Contributor Author

retyui commented Sep 11, 2021 •
edited

close, because I move typings to DefinitelyTyped/DefinitelyTyped#55702

where I add tests and split support :

  • TS@3.9-4.2 : only camelcase syntax <FbtParam name="name">{person.getName()}</FbtParam>
  • TS@4.2+ : xml namespaces + camelcase syntax <fbt:param name="name">{person.getName()}</fbt:param>

@retyui retyui closed this Sep 11, 2021
@retyui retyui deleted the add-typescript-definitions branch September 11, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@retyui @facebook-github-bot