Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: upgrade rn-demo-app to RN 0.64.0 #234

Open
wants to merge 7 commits into
base: rn-demo-app
Choose a base branch
from

Conversation

ecreeth
Copy link
Contributor

@ecreeth ecreeth commented May 26, 2021

Summary

In 8fdbce6 the dependencies were updated to 0.64.0 but not in the Android native side.

  • update android code to 0.64.0
  • update react-native-fbt to 0.0.5
  • added temporal fix to react-native-fbt. In version 0.0.3 this package has a mistake; its calling a file that doesn't exists in that location. The js directory is not found
    "main": "js/NativeFbtModule.js",

Now the application build successfully

1 1

The react-native-fbt package needs to be updated to 0.0.3. In new versions of React Native the TurboModuleRegistry is found in another destination, so the application will not compile.

import TurboModuleRegistry from 'react-native/TurboModule/TurboModuleRegistry';

This is resolved in 0.0.3

import {TurboModuleRegistry} from 'react-native';

Test plan

yarn android 

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 26, 2021
@ecreeth ecreeth marked this pull request as ready for review May 26, 2021 15:11
@ecreeth
Copy link
Contributor Author

ecreeth commented May 26, 2021

cc @hramos

@facebook-github-bot
Copy link
Contributor

@jrwats has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ecreeth has updated the pull request. You must reimport the pull request before landing.

@ecreeth
Copy link
Contributor Author

ecreeth commented May 27, 2021

I just update the react-native-fbt to 0.0.3 and added a temporal fix to it. Everything is OK now.
I'll send another PR to fix that issue.

@facebook-github-bot
Copy link
Contributor

@ecreeth has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ecreeth
Copy link
Contributor Author

ecreeth commented Jun 22, 2021

@hramos bump version to 0.0.4 but is not published in npm yet. We need to use version 0.0.4 to build successful

@jrwats
Copy link
Contributor

jrwats commented Aug 6, 2021

@hramos bump version to 0.0.4 but is not published in npm yet. We need to use version 0.0.4 to build successful

0.0.5 is published as of last week, heads up.

@facebook-github-bot
Copy link
Contributor

@ecreeth has updated the pull request. You must reimport the pull request before landing.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@ecreeth has updated the pull request. You must reimport the pull request before landing.

@ecreeth
Copy link
Contributor Author

ecreeth commented Aug 6, 2021

@jrwats is done!

@facebook-github-bot
Copy link
Contributor

@kayhadrin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ecreeth
Copy link
Contributor Author

ecreeth commented Aug 12, 2021

@kayhadrin What's failing? Can I solve the problem or is it an internal-related issue?

@retyui
Copy link
Contributor

retyui commented Nov 11, 2021

More easily maintain RN updates by using react-native-test-app

Here is a video of how it works in Microsoft https://www.youtube.com/watch?v=DAEnPV78rQc

@kayhadrin
Copy link
Collaborator

@kayhadrin What's failing? Can I solve the problem or is it an internal-related issue?

Sorry it's been a while since this PR was submitted and it's getting rebase conflicts.
It'd be great to know if it's still needed nowadays.
cc: @hramos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants