Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global toggle code wrap button #9349

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OzakIOne
Copy link
Collaborator

@OzakIOne OzakIOne commented Sep 27, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

As discussed in the related issue, I think it would be great to have a synchronized code wrap button and also save the state in localStorage

Then maybe we could have a global configuration with also the possibility to have a per block configuration

For now this is a wip the state is in local storage however when refreshing code wrap style is reset to the default (false)

Test Plan

Test links

Deploy preview: https://deploy-preview-9349--docusaurus-2.netlify.app/

Related issues/PRs

#7875

@netlify
Copy link

netlify bot commented Sep 27, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 86ea394
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6515a3f1f775c50007c42063
😎 Deploy Preview https://deploy-preview-9349--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 74 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 73 🟢 98 🟢 92 🟢 100 🟠 89 Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants