Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node engine version 18 #9348

Merged
merged 12 commits into from Sep 28, 2023
Merged

Conversation

OzakIOne
Copy link
Collaborator

@OzakIOne OzakIOne commented Sep 27, 2023

Breaking change

Docusaurus v3 drops support for Node 16 (end-of-life September 2023) and now requires Node.js >= 18.0

Motivation

Require Node.js >= 18

As discussed in the related issue, node 16 is EOL since 11 September 2023

Test Plan

CI

Test links

https://deploy-preview-9348--docusaurus-2.netlify.app/

Related issues/PRs

#7455 (comment)

@facebook-github-bot
Copy link
Contributor

Hi @OzakIOne!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 27, 2023
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the examples modification that should be reverted.

CI will tell us if it works fine

- [Node.js](https://nodejs.org/en/download/) version 16.14 or above:
- [Node.js](https://nodejs.org/en/download/) version 18.0 or above:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples are generated with a script and are used to populate stackblitz/codesandbox templates.

They should represent the stable version of Docusaurus and shouldn't be updated manually.

These example changes should be reverted because examples are still using Docusaurus v2 (which supports Node 16.14)

They are basically new sites initialized with npx create-docusaurus@latest, so if you modify create-docusaurus these will be self-updated on next regeneration after a stable release. We don't have examples for unstable/next/alpha/beta/rc/canary versions.

@slorber slorber added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label Sep 28, 2023
@netlify
Copy link

netlify bot commented Sep 28, 2023

[V2]

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65153697692f1e6873f7837a
😎 Deploy Preview https://deploy-preview-9348--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 80 🟢 98 🟢 92 🟢 100 🟠 89 Report

@netlify
Copy link

netlify bot commented Sep 28, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a40573
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6515881f949339000853bd7f
😎 Deploy Preview https://deploy-preview-9348--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Sep 28, 2023
@argos-ci
Copy link

argos-ci bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Sep 28, 2023, 2:26 PM

@slorber slorber merged commit bde9cfd into facebook:main Sep 28, 2023
29 of 31 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants