Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-translations): translation for Uzbek (uz) #9209

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Zukhrik
Copy link

@Zukhrik Zukhrik commented Aug 7, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @Zukhrik!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Aug 7, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 25a8c59
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64d615328eae2c0008de9aac
😎 Deploy Preview https://deploy-preview-9209--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 74 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 71 🟢 100 🟢 92 🟢 100 🟠 89 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 7, 2023
@Josh-Cena Josh-Cena changed the title feat: (new locale) created translated files to uzbek language feat(theme-translations): translation for Uzbek (uz) Aug 9, 2023
@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Aug 9, 2023
@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Aug 9, 2023

I wonder if we should have a threshold to limit the number of languages we have. I understand that every language is potentially useful to some users, but we need to weigh between out-of-the-box usefulness and the extra install size this brings to everyone, including the 99.9% of users that don't need it. Plus there's maintenance issues, quality control, etc.

@slorber WDYT?

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I can't be sure the translations are good but I notice errors on the plural forms.

Please read this part to understand how to handle plurals:
#3526

Uzbek only has 2 cardinal plural forms, according to

CleanShot 2023-08-10 at 16 07 22@2x

Thus, your pluralized translations should only contain 2 parts and not 3.

Also the placeholders should not be translated

@slorber
Copy link
Collaborator

slorber commented Aug 10, 2023

I wonder if we should have a threshold to limit the number of languages we have. I understand that every language is potentially useful to some users, but we need to weigh between out-of-the-box usefulness and the extra install size this brings to everyone, including the 99.9% of users that don't need it. Plus there's maintenance issues, quality control, etc.

@slorber WDYT?

This probably does not increase install size that much IMHO. There are lower hanging fruits to consider, like inlining our dependencies like Next.js does, which as a much more significant impact. I don't think it's time to optimize this part yet, and the maintenance remains reasonable so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants