Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): bump update-notifier #9156

Closed

Conversation

WikiRik
Copy link

@WikiRik WikiRik commented Jul 19, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Backport of #8660 for v2. It fixes #8277 for an unlikely security vulnerability. Either way it's good to have it solved if it is an easy fix. I didn't run all CI checks, and I was hoping I could do it as a draft PR but it does not seem that way unfortunately. SO apologies if I need to close this again since there is more work to be done to upgrade update-notifier.

Test Plan

Test links

Deploy preview: https://deploy-preview-9156--docusaurus-2.netlify.app/

Related issues/PRs

Backport of #8660
Fixes #8277 for v2

@facebook-github-bot
Copy link
Contributor

Hi @WikiRik!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Jul 19, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 14efb0b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64b7dd9e2a71b90009a3cd5e
😎 Deploy Preview https://deploy-preview-9156--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 19, 2023
@WikiRik WikiRik marked this pull request as ready for review July 19, 2023 13:07
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 21, 2023
@slorber
Copy link
Collaborator

slorber commented Jul 21, 2023

Thanks

I added the tag "to backport" to the original PR, which means that we'll backport it as part of our regular backport process during the next v2 releases. We don't expect external contributors to backport things to v2, I do all the backports myself at once.

@slorber slorber closed this Jul 21, 2023
@WikiRik WikiRik deleted the bump-update-notifier-v2 branch July 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants