Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable nx as task runner for lerna #8573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AgentEnder
Copy link
Contributor

@AgentEnder AgentEnder commented Jan 23, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • [ na ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • [ na ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Follows from #8447. Another follow up PR will finally enable caching 😄

Test Plan

Nothing should change, dev tooling dependency upgrade only.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#8318
#8447

fix #7333

@netlify
Copy link

netlify bot commented Jan 23, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit b9e2394
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64fa9153bbd79600081964ad
😎 Deploy Preview https://deploy-preview-8573--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 77 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 78 🟢 98 🟢 92 🟢 100 🟠 89 Report

package.json Outdated Show resolved Hide resolved
@AgentEnder
Copy link
Contributor Author

Hey @slorber! It's hard to believe its taken so long to come back to this, and for that I apologize. Nonetheless, the PR should be good to go now if you are able to take another look. Let me know if there is anything else I can do - next steps for this repo would be to start setting up caching for local dev, and then finally getting the remote cache setup with nx-cloud (which is free for OSS)

@slorber
Copy link
Collaborator

slorber commented Sep 19, 2023

Thanks, I'll check this out after v3 is out because I'd prefer to focus on that for now ;)

@AgentEnder
Copy link
Contributor Author

Yep, no worries. Thanks for the patience on this one @slorber 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Lerna to alternative toolset (like Nx)
3 participants