Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ideal-image): do not pass down img prop #8250

Merged
merged 2 commits into from Oct 26, 2022
Merged

fix(ideal-image): do not pass down img prop #8250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc6fab5
fix(ideal-image): do not pass down `img` prop
lex111 Oct 26, 2022
90acd46
Simplify code
lex111 Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 4 additions & 10 deletions packages/docusaurus-plugin-ideal-image/src/theme/IdealImage/index.tsx
View file
Open in desktop
Expand Up @@ -81,25 +81,19 @@ function getMessage(icon: IconKey, state: State) {
}

export default function IdealImage(props: Props): JSX.Element {
const {alt, className, img} = props;
const {img, ...propsRest} = props;

// In dev env just use regular img with original file
if (typeof img === 'string' || 'default' in img) {
return (
<img
src={typeof img === 'string' ? img : img.default}
className={className}
alt={alt}
{...props}
/>
// eslint-disable-next-line jsx-a11y/alt-text
<img src={typeof img === 'string' ? img : img.default} {...propsRest} />
);
}

return (
<ReactIdealImage
{...props}
alt={alt}
className={className}
{...propsRest}
height={img.src.height ?? 100}
width={img.src.width ?? 100}
placeholder={{lqip: img.preSrc}}
Expand Down