Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-classic): fix SkipToContent without JS , refactor, make it public theming API #8204

Merged
merged 7 commits into from Oct 19, 2022
Merged

fix(theme-classic): fix SkipToContent without JS , refactor, make it public theming API #8204

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee90a0b
fix(theme-classic): Use native href for skip to content #6411.
mturoci Oct 11, 2022
fdf3bd8
chore: Address review comments.
mturoci Oct 13, 2022
590d303
more skipToContent refactor
slorber Oct 19, 2022
81fa5e7
Merge branch 'main' into fix/issue-6411
slorber Oct 19, 2022
d135d8a
mark SkipToContent as safe to swizzle
slorber Oct 19, 2022
95abdbe
fix duplicate translationId in theme-common
slorber Oct 19, 2022
4c51eba
typo
slorber Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/docusaurus-theme-classic/src/theme/Layout/index.tsx
View file
Open in desktop
Expand Up @@ -42,6 +42,7 @@ export default function Layout(props: Props): JSX.Element {
<Navbar />

<div
id="main-wrapper"
mturoci marked this conversation as resolved.
Show resolved Hide resolved
className={clsx(
ThemeClassNames.wrapper.main,
styles.mainWrapper,
Expand Down
6 changes: 4 additions & 2 deletions packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx
View file
Open in desktop
Expand Up @@ -18,8 +18,10 @@ export default function SkipToContent(): JSX.Element {
ref={containerRef}
role="region"
aria-label={translate({id: 'theme.common.skipToMainContent'})}>
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
<a href="#" className={styles.skipToContent} onClick={handleSkip}>
<a
href="#main-wrapper"
className={styles.skipToContent}
onClick={handleSkip}>
<Translate
id="theme.common.skipToMainContent"
description="The skip to content label used for accessibility, allowing to rapidly navigate to main content with keyboard tab/enter navigation">
Expand Down