Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translations): complete turkish theme default translations #8105

Merged
merged 3 commits into from Sep 28, 2022

Conversation

ramazansancar
Copy link
Contributor

@ramazansancar ramazansancar commented Sep 16, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-8105--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @ramazansancar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Sep 16, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 61f90aa
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6324724b4301ce0009d9df2f
😎 Deploy Preview https://deploy-preview-8105--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 92 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 71 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 16, 2022
@ramazansancar ramazansancar changed the title tr localization updated. fix(theme-translations) tr localization updated Sep 16, 2022
@ramazansancar ramazansancar changed the title fix(theme-translations) tr localization updated fix(theme-translations): tutkish localization updated Sep 16, 2022
@ramazansancar ramazansancar changed the title fix(theme-translations): tutkish localization updated fix(theme-translations): (tr) turkish localization updated Sep 16, 2022
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 28, 2022
@slorber slorber changed the title fix(theme-translations): (tr) turkish localization updated fix(theme-translations): complete turkish theme default translations Sep 28, 2022
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, difficult to review for me but better than no translation 😄

@slorber slorber merged commit 292d728 into facebook:main Sep 28, 2022
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Sep 28, 2022
@ramazansancar
Copy link
Contributor Author

Thanks, difficult to review for me but better than no translation 😄

Thank you, it was fun for me 😄

@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants